1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/load_cfg.c

    From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon Sep 25 20:36:18 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/566c41b6ab3cbbe97fc25009
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Allow text strings to be identified by number (instead of ID)

    for those that want to use cryptic numbers rather than human-readable names.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Mon Sep 25 21:39:43 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/b44b6ea733cd12a51560b980
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix off-by-one issue in previous commit, text.dat string numbers are 1-based

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Dec 19 02:48:11 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/4197ced7afc511120e8d284b
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix new crash on startup for Windows build

    load_cfg() calls free_cfg() before do_cryptInit() is called, so the ssl_rwlock was uninitialized here.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Dec 19 02:51:09 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/c15b7a2f57ccf21ad44f7e3c
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix new clang warning: incompatible pointer types passing 'long *' to parameter of type 'int *'

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deucе@VERT to Git commit to main/sbbs/master on Tue Dec 19 06:29:23 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/587eca57b14dc020487c22d8
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    We don't need to set tls_certificate to -1 in prep_cfg() because
    it's only called from load_cfg() which has already set it to -1.

    We also don't need to check prepped twice to make sure it's extra true.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Dec 19 06:31:01 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/d47a2258d7f870e139cdf0b4
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Always set scfg.prepped to FALSE in free_cfg()

    Remove some redundant redundancies, redundantly

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Tue Jan 23 17:17:37 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/0503c2900a17ddd91986b312
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix uninitialized cfg.colors[] element usage caught by Deuce (and Clang?)

    Conditional jump or move depends on uninitialised value(s)
    at 0x4AE768D: sbbs_t::backfill(char const*, float, int, int) (con_out.cpp:1445)
    by 0x4AE7855: sbbs_t::progress(char const*, int, int, int) (con_out.cpp:1467)
    by 0x4AE91A9: ProgressLoadingMsgPtrs(void*, int, int) (data_ovl.cpp:27)
    by 0x4C7C577: getmsgptrs (userdat.c:3972)
    by 0x4AE9144: sbbs_t::getmsgptrs() (data_ovl.cpp:39)
    by 0x4BF9237: sbbs_t::logon() (logon.cpp:452)
    by 0x4AC1CE2: sbbs_t::answer() (answer.cpp:636)
    by 0x4C0FD37: node_thread(void*) (main.cpp:4277)

    Introduced in commit 48e7520e (when colors was converted from a byte array
    to a uint array), we weren't memsetting the right number of bytes.

    Since color is not an array of ints (not bytes), memset (of non-zero values) isn't really the right initialization approach anyway. Now using a for-loop.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Fri Jun 21 04:26:42 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/26920170a050ba2300ecebc7
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Fix small memory leak when loading lib "Auto-Add Subs" feature enabled

    caught by valgrind

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Fri Dec 6 22:38:28 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/a4dea66efb569f5681913d56
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Check return value of smb_create() in smb_open_dir()

    Resolves CID 515657

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Thu Jan 16 01:09:08 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/a35294c13c0056b163095beb
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Remove dead code, fixing CID 530828

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on macOS)@VERT to Git commit to main/sbbs/master on Sun Mar 9 22:57:35 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/7e1189ca981b16ec9335c84e
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Don't try to load node.ini if no nodes are configured in main.ini

    But set the error string to hopefully be printed as a warning

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Thu Mar 27 18:50:18 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/f09df78e24809b7eb797cac7
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    Better range checking of the configure node paths

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Wed Apr 2 22:58:19 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/e47530ffd0e039fb304806b5
    Modified Files:
    src/sbbs3/load_cfg.c
    Log Message:
    sys_timezone() no longer modifies the scfg_t.sys_timezone member itself

    ... just the returned copy (when toggling the DST flag).

    This resolve the issue of SCFG->System menu detecting changes by the sysop
    (and prompting to Save Changes when exiting) when no changes were actually made, just that DST had been auto-enabled/disabled based on the date.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net